Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [BETA-116][DHIS2-15896] validate values assigned from the rules engine #3612

Merged
merged 5 commits into from
Jul 9, 2024
Merged

fix: [BETA-116][DHIS2-15896] validate values assigned from the rules engine #3612

merged 5 commits into from
Jul 9, 2024

Conversation

simonadomnisoru
Copy link
Contributor

@simonadomnisoru simonadomnisoru commented Apr 18, 2024 •
edited by jira bot
Loading

BETA-116 and DHIS2-15896

Tech summary:

  • On componentDidUpdate, validate all the values assigned from the program's rules engine. Some use cases where the validation is needed:
    • Assign null/blank to a field that expects a required value
    • Assign a non-unique value to a field that expects a unique value

@simonadomnisoru simonadomnisoru marked this pull request as ready for review April 18, 2024 09:18
@simonadomnisoru simonadomnisoru requested a review from a team as a code owner April 18, 2024 09:18
JoakimSM
JoakimSM reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@JoakimSM JoakimSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll digest this approach over the weekend. At the very least I don't think we should dispatch from render. Let's discuss over the weekend.

@simonadomnisoru simonadomnisoru marked this pull request as draft April 23, 2024 12:41
@simonadomnisoru simonadomnisoru marked this pull request as ready for review April 25, 2024 07:54
@simonadomnisoru
Copy link
Contributor Author

I'll digest this approach over the weekend. At the very least I don't think we should dispatch from render. Let's discuss over the weekend.

Hey @JoakimSM, I changed the approach and dispatch from componentDidUpdate instead. Thanks for the feedback!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3612--dhis2-capture.netlify.app

@linadhis2
Copy link

LGTM from QA perspective

@simonadomnisoru simonadomnisoru merged commit 459ab9a into master Jul 9, 2024
45 checks passed
@simonadomnisoru simonadomnisoru deleted the BETA-116 branch July 9, 2024 12:04
dhis2-bot added a commit that referenced this pull request Jul 9, 2024
@dhis2-bot
chore(release): cut 100.70.7 [skip release]
71d1b6f 
## [100.70.7](v100.70.6...v100.70.7) (2024-07-09)

### Bug Fixes

* [BETA-116][DHIS2-15896] validate values assigned from the rules engine ([#3612](#3612)) ([459ab9a](459ab9a))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.70.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@simonadomnisoru simonadomnisoru mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoakimSM JoakimSM JoakimSM approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonadomnisoru @linadhis2 @dhis2-bot @JoakimSM